Avoid slow fallback Matrix constructor when converting Q from QR, #29865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LQ and Hessenberg to Matrix.
It would have been nice to also make
LQPackedQ <: AbstractQ
but it stores the reflectors as rows so it wouldn't work. More generally, we should consider to fold all theLQ
stuff into theQR
structs since theLQ
would simply beAdjoint{T,QRQ{T,Adjoint{T,Matrix{T}}}
. It's a bit convoluted but most users wouldn't need to ever write this.Fixes JuliaLang/LinearAlgebra.jl#582